Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotype removed #1472

Closed
jayvdb opened this issue Mar 3, 2017 · 10 comments · Fixed by #1487
Closed

gotype removed #1472

jayvdb opened this issue Mar 3, 2017 · 10 comments · Fixed by #1487

Comments

@jayvdb
Copy link
Member

jayvdb commented Mar 3, 2017

All builds failing with

$ go get -u golang.org/x/tools/cmd/gotype
package golang.org/x/tools/cmd/gotype: cannot find package "golang.org/x/tools/cmd/gotype" in any of:
	/home/travis/.gimme/versions/go1.7.linux.amd64/src/golang.org/x/tools/cmd/gotype (from $GOROOT)
	/home/travis/gopath/src/golang.org/x/tools/cmd/gotype (from $GOPATH)
@jayvdb
Copy link
Member Author

jayvdb commented Mar 3, 2017

So this would be caused by golang/tools@f5a6ee1
Review: https://go-review.googlesource.com/#/c/37657/

@jayvdb jayvdb changed the title gotype missing gotype removed Mar 3, 2017
@jayvdb
Copy link
Member Author

jayvdb commented Mar 3, 2017

alecthomas/gometalinter#91 is about the same problem, but they knew about it in advance.
alecthomas/gometalinter#206 is their current discussion about it.
cc @yukiisbored

@jayvdb
Copy link
Member Author

jayvdb commented Mar 3, 2017

Do we try to re-implement this using a different command? I see quite a few alternatives mentioned in the various issues about this deprecation.

Or deprecate the bear?
If we deprecate it, either we remove it from test coverage, or we need to create our own repo with the old code in it, as the original is gone and go doesnt do versioning.

Or do we effectively delete the bear, perhaps with a placeholder to ensure an appropriate warning message is emitted?

@yukiisbored
Copy link
Member

yukiisbored commented Mar 3, 2017

I'm not quite sure which is the best option. It seems to be "on going" at the moment. Part of me thinks it'll be part of the go command but not quite sure. Scratch that, golang/go#12703 (comment)

@yukiisbored
Copy link
Member

After browsing the repository, it looks like they moved it here: https://github.com/golang/go/blob/master/src/go/types/gotype.go

@yukiisbored
Copy link
Member

Still have no idea how to use go get for that.

@yukiisbored
Copy link
Member

yukiisbored commented Mar 3, 2017

The best decision that I can think of for now is to deprecate this bear and create a new one that uses go build -i

@jayvdb
Copy link
Member Author

jayvdb commented Mar 3, 2017

If necessary, we can git clone the repo, and build the moved tool from the clone?

@yukiisbored
Copy link
Member

yukiisbored commented Mar 3, 2017

@jayvdb Most likely that's the only option. Actually, we can just clone the release-branch.go1.8 branch from the golang/tools repository.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 4, 2017

Can we create a copy of just the necessary files, and put them in a repo, so it is quick to clone and go get also works?

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 6, 2017
The main repository deleted gotype in
golang/tools@f5a6ee1e

As the coala-bears builds depend on fetching a working
gotype, a fork is required.

Fixes coala#1472
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 6, 2017
The main repository deleted gotype in
golang/tools@f5a6ee1e

As the coala-bears builds depend on fetching a working gotype,
fork https://github.com/jayvdb/gotype has been created and used.

Fixes coala#1472
jayvdb added a commit to jayvdb/docker-coala-base that referenced this issue Mar 6, 2017
The original gotype command has been removed.

Related to coala/coala-bears#1472
jayvdb added a commit to jayvdb/docker-coala-base that referenced this issue Apr 28, 2017
The original gotype command has been removed.

Related to coala/coala-bears#1472
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
The main repository deleted gotype in
golang/tools@f5a6ee1e

As the coala-bears builds depend on fetching a working gotype,
fork https://github.com/jayvdb/gotype has been created and used.

Fixes coala#1472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants