Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationBear is still not recognizing nasty strings correctly #1006

Closed
coala-bot opened this issue Nov 17, 2016 · 7 comments
Closed

AnnotationBear is still not recognizing nasty strings correctly #1006

coala-bot opened this issue Nov 17, 2016 · 7 comments

Comments

@coala-bot
Copy link

tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
|  48| ••••••••••••"""•printf•(•"i•is•%d"•,•i•)•;•}•})\n""")
|    | [MAJOR] AnnotationBear:
|    | """ has no closure
|    | *0: Do nothing
|    |  1: Open the affected file(s) in an editor.
|    | Enter number (Ctrl-D to exit): 

tests/general/QuotesBearTest.py
|  99| •••••••••••••••••••••••••••••"•'A•single•quoted•string•with•\"•in•it'\n")
|    | [MAJOR] AnnotationBear:
|    | ' has no closure
|    | *0: Do nothing
|    |  1: Open the affected file(s) in an editor.
|    | Enter number (Ctrl-D to exit): %

CC @abhsag24 as he claimed to have solved that :P

Opened via gitter by @sils

@abh3po
Copy link
Member

abh3po commented Nov 17, 2016

:O will look into it today, i ran the quotes bear before making the PR though? it had no issues for me :( .

@sils
Copy link
Member

sils commented Nov 17, 2016

really? Am I doing something wrong :/

@sils
Copy link
Member

sils commented Nov 17, 2016

nope, I still seem to be able to reproduce that exactly

@abh3po
Copy link
Member

abh3po commented Nov 17, 2016

abh3po added a commit that referenced this issue Nov 17, 2016
Right now AnnotationBear searches 1 position after annotation
which caused problems in
tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
and
tests/general/QuotesBearTest.py

Fixes #1006
@sils
Copy link
Member

sils commented Nov 17, 2016

So can we get it fixed? :)

On Nov 17, 2016 7:32 PM, "Abhay Raizada" [email protected] wrote:

@sils https://github.com/sils the error is caused due to this line
https://github.com/coala/coala-bears/blob/master/tests/
c_languages/codeclone_detection/ClangASTPrintBearTest.py#L39


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1006 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFc6KKwo-7WFaX_ij723y4MwEU0iu4srks5q_J21gaJpZM4K1GXt
.

@abh3po
Copy link
Member

abh3po commented Nov 17, 2016

yes i opened the PR! :D it works locally for me now

@abh3po
Copy link
Member

abh3po commented Nov 17, 2016

sorry about the confusion earlier i thought it fixed it i didnt see the AnnotationBear result amongst all the QuotesBear results
image

abh3po added a commit that referenced this issue Nov 19, 2016
Right now AnnotationBear searches 1 position after annotation
which caused problems in
tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
and
tests/general/QuotesBearTest.py

Fixes #1006
sils pushed a commit that referenced this issue Nov 19, 2016
Right now AnnotationBear searches 1 position after annotation
which caused problems in
tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
and
tests/general/QuotesBearTest.py

Fixes #1006
sils pushed a commit that referenced this issue Nov 19, 2016
Right now AnnotationBear searches 1 position after annotation
which caused problems in
tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
and
tests/general/QuotesBearTest.py

Fixes #1006
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Right now AnnotationBear searches 1 position after annotation
which caused problems in
tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py
and
tests/general/QuotesBearTest.py

Fixes coala#1006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants