-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnnotationBear is still not recognizing nasty strings correctly #1006
Comments
:O will look into it today, i ran the quotes bear before making the PR though? it had no issues for me :( . |
really? Am I doing something wrong :/ |
nope, I still seem to be able to reproduce that exactly |
@sils the error is caused due to this line https://github.com/coala/coala-bears/blob/master/tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py#L39 |
Right now AnnotationBear searches 1 position after annotation which caused problems in tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py and tests/general/QuotesBearTest.py Fixes #1006
So can we get it fixed? :) On Nov 17, 2016 7:32 PM, "Abhay Raizada" [email protected] wrote:
|
yes i opened the PR! :D it works locally for me now |
Right now AnnotationBear searches 1 position after annotation which caused problems in tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py and tests/general/QuotesBearTest.py Fixes #1006
Right now AnnotationBear searches 1 position after annotation which caused problems in tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py and tests/general/QuotesBearTest.py Fixes #1006
Right now AnnotationBear searches 1 position after annotation which caused problems in tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py and tests/general/QuotesBearTest.py Fixes #1006
Right now AnnotationBear searches 1 position after annotation which caused problems in tests/c_languages/codeclone_detection/ClangASTPrintBearTest.py and tests/general/QuotesBearTest.py Fixes coala#1006
CC @abhsag24 as he claimed to have solved that :P
Opened via gitter by @sils
The text was updated successfully, but these errors were encountered: