Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get some form of merge restriction #50

Closed
sims1253 opened this issue Dec 15, 2016 · 2 comments
Closed

Get some form of merge restriction #50

sims1253 opened this issue Dec 15, 2016 · 2 comments

Comments

@sims1253
Copy link
Member

sims1253 commented Dec 15, 2016

Would be nice to make it impossible to merge cEPs with only one ack

@sils
Copy link
Member

sils commented Dec 28, 2016

there's services FWIW and on long term we could of course let gitmate require two acks

@jayvdb
Copy link
Member

jayvdb commented May 7, 2018

This can now be done using GitHub branch protection, which can require multiple approvers.

Also we can restrict who can approve, which requires a CODEOWNERS file

Lets start by letting all developers be approvers, and requiring two approvers.

Then we still have gitmate ack's which can only be done by a maintainer prior to merge. So that is a third approver if the first two were not a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants