fix: proxy to source registry when package is public scoped with enco…

…ded path (#1415)
cnpm · Dec 1, 2018 · 9bdb695 · 9bdb695
1 parent 8bd0a2d
commit 9bdb695
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/middleware/proxy_to_npm.js b/middleware/proxy_to_npm.js
@@ -40,7 +40,7 @@ module.exports = function (options) {
       return yield next;
     }
 
-    var pathname = this.path;
+    var pathname =  decodeURIComponent(this.path);
 
     var isScoped = false;
     var isPublichScoped = false;

diff --git a/test/middleware/proxy_to_npm.test.js b/test/middleware/proxy_to_npm.test.js
@@ -48,6 +48,13 @@ describe('test/middleware/proxy_to_npm.test.js', () => {
         .expect('Location', config.sourceNpmRegistry + '/@jkroso/type')
         .expect(302, done);
     });
+
+    it('should proxy to source registry when package is public scoped with encoded path', done => {
+      request(registry)
+        .get('/@jkroso%2Ftype')
+        .expect('Location', config.sourceNpmRegistry + '/@jkroso%2Ftype')
+        .expect(302, done);
+    });
   });
 
   describe('dist-tags', () => {