-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add istio-ambient stack #49
base: main
Are you sure you want to change the base?
Conversation
7d5de72
to
9da013d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial comments to give you some initial food for thoughts
@jaypz
This way we can make those stack(s) reusable. Then we can add instructions for using those stacks if user wants observability using kiali. @blakeromano @nabuskey What you think about it? |
I think I struggle with it slightly... I think packages ideally should be re-usable and as small as possible (multiple packages can make up a stack which multiple stacks make up an IDP) like a separate package for all 3 that then can integrate together is great in my opinion for a stack... I think maybe one limitation of IDPBuilder being able to use a "package manager" is there is no way to remote change a package, for example I can't say actually use this Grafana package but make it integrate with Prometheus and Tempo in one case, but now I may want to change it to integrate with no Prometheus now but just want Tempo. I think for this use case, I lean towards observability stuff being one stack is fine but I really do wonder how we should think of having stacks really be more "package" like where I can pick and choose packages that I can quickly configure to integrate with X over Y instead. |
Thanks for the feedback, I'll work on splitting things out; I struggled with this a bit myself because while a base istio install on its own is great and we plan to use it for CI / Unit tests internally for like validation, but if folks are experimenting with istio usage/features having kiali (which requires prometheus) and tempo/grafana to view traces really helps visualize the traffic flow within istio mesh |
adds istio ambient stack with additional observability component Signed-off-by: John Pease <[email protected]>
additionally updated docs to add a note on the built in path-based routing feature Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
64d8088
to
4222619
Compare
@punkwalker @blakeromano I went ahead and removed the observability stack here and hope to just get basic istio package set Since there seems to be activity on some observability stacks that seem like they'll come to the repo soon, I can work on integrating istio with those stacks once available |
Signed-off-by: John Pease <[email protected]>
adds a new istio ambient stack with optional observability component