Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add istio-ambient stack #49

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jaypz
Copy link

@jaypz jaypz commented Dec 16, 2024

adds a new istio ambient stack with optional observability component

@jaypz jaypz force-pushed the feat/istio-ambient-stack branch from 7d5de72 to 9da013d Compare December 16, 2024 16:09
Copy link

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial comments to give you some initial food for thoughts

istio-ambient/README.md Outdated Show resolved Hide resolved
istio-ambient/istio-base/istio.yaml Outdated Show resolved Hide resolved
istio-ambient/istio-base/istio.yaml Outdated Show resolved Hide resolved
istio-ambient/istio-base/istio.yaml Outdated Show resolved Hide resolved
@jaypz jaypz requested a review from blakeromano December 16, 2024 16:59
@punkwalker
Copy link

punkwalker commented Jan 7, 2025

@jaypz
Two approaches I am thinking of :

  1. Separate Prometheus, Grafana-Tempo and OTEL in individual stacks?
  2. Put all these 3 in a single observability stack

This way we can make those stack(s) reusable. Then we can add instructions for using those stacks if user wants observability using kiali.
Ref: #11

@blakeromano @nabuskey What you think about it?

@blakeromano
Copy link

I think I struggle with it slightly...

I think packages ideally should be re-usable and as small as possible (multiple packages can make up a stack which multiple stacks make up an IDP) like a separate package for all 3 that then can integrate together is great in my opinion for a stack... I think maybe one limitation of IDPBuilder being able to use a "package manager" is there is no way to remote change a package, for example I can't say actually use this Grafana package but make it integrate with Prometheus and Tempo in one case, but now I may want to change it to integrate with no Prometheus now but just want Tempo.

I think for this use case, I lean towards observability stuff being one stack is fine but I really do wonder how we should think of having stacks really be more "package" like where I can pick and choose packages that I can quickly configure to integrate with X over Y instead.

@jaypz
Copy link
Author

jaypz commented Jan 8, 2025

Thanks for the feedback, I'll work on splitting things out;

I struggled with this a bit myself because while a base istio install on its own is great and we plan to use it for CI / Unit tests internally for like validation, but if folks are experimenting with istio usage/features having kiali (which requires prometheus) and tempo/grafana to view traces really helps visualize the traffic flow within istio mesh

jaypz added 6 commits January 17, 2025 11:55
adds istio ambient stack with additional observability component

Signed-off-by: John Pease <[email protected]>
additionally updated docs to add a note on the built in path-based routing feature

Signed-off-by: John Pease <[email protected]>
@jaypz jaypz force-pushed the feat/istio-ambient-stack branch from 64d8088 to 4222619 Compare January 17, 2025 17:07
@jaypz
Copy link
Author

jaypz commented Jan 17, 2025

@punkwalker @blakeromano I went ahead and removed the observability stack here and hope to just get basic istio package set

Since there seems to be activity on some observability stacks that seem like they'll come to the repo soon, I can work on integrating istio with those stacks once available

Signed-off-by: John Pease <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants