-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add istio-ambient stack #49
base: main
Are you sure you want to change the base?
Conversation
adds istio ambient stack with additional observability component Signed-off-by: John Pease <[email protected]>
7d5de72
to
9da013d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial comments to give you some initial food for thoughts
`idpbuilder create -p https://github.com/cnoe-io/stacks//isto-ambient/istio-base -p https://github.com/cnoe-io/stacks//isto-ambient/observability` | ||
|
||
|
||
# Observability UIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a good idea to put the details of what the urls are on path based routing (if that is supported) or note that only host based routing is supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a note on this; I've not tested the built-in path based routing feature
parameters: | ||
- name: 'profile' | ||
value: 'ambient' | ||
chart: cni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious if the CNI helm chart conflicts with other CNIs I think according to https://istio.io/latest/docs/setup/additional-setup/cni/#prerequisites-for-use we should be fine here since we are in a kind cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't unless its a fairly obscure CNI, this isn't a CNI in itself but a cni plugin - most CNIs such as Cilium, AWS, Calico, Kind's etc. all work without any issues 👍
additionally updated docs to add a note on the built in path-based routing feature Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
Signed-off-by: John Pease <[email protected]>
adds a new istio ambient stack with optional observability component