Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add istio-ambient stack #49

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jaypz
Copy link

@jaypz jaypz commented Dec 16, 2024

adds a new istio ambient stack with optional observability component

adds istio ambient stack with additional observability component

Signed-off-by: John Pease <[email protected]>
@jaypz jaypz force-pushed the feat/istio-ambient-stack branch from 7d5de72 to 9da013d Compare December 16, 2024 16:09
Copy link

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial comments to give you some initial food for thoughts

`idpbuilder create -p https://github.com/cnoe-io/stacks//isto-ambient/istio-base -p https://github.com/cnoe-io/stacks//isto-ambient/observability`


# Observability UIs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a good idea to put the details of what the urls are on path based routing (if that is supported) or note that only host based routing is supported

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a note on this; I've not tested the built-in path based routing feature

istio-ambient/istio-base/istio.yaml Outdated Show resolved Hide resolved
istio-ambient/istio-base/istio.yaml Outdated Show resolved Hide resolved
parameters:
- name: 'profile'
value: 'ambient'
chart: cni

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious if the CNI helm chart conflicts with other CNIs I think according to https://istio.io/latest/docs/setup/additional-setup/cni/#prerequisites-for-use we should be fine here since we are in a kind cluster.

Copy link
Author

@jaypz jaypz Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't unless its a fairly obscure CNI, this isn't a CNI in itself but a cni plugin - most CNIs such as Cilium, AWS, Calico, Kind's etc. all work without any issues 👍

additionally updated docs to add a note on the built in path-based routing feature

Signed-off-by: John Pease <[email protected]>
@jaypz jaypz requested a review from blakeromano December 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants