copy from idpbuilder example dir #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manabu McCloskey <[email protected]>
csantanapr
reviewed
May 25, 2024
| @@ -0,0 +1,23 @@ | |||
| apiVersion: argoproj.io/v1alpha1 | |||
There was a problem hiding this comment.
I think the application yaml should go inside the folder representing a package instead of outside
There was a problem hiding this comment.
Not sure if I follow. This is how it's laid out in the examples directory in the idpbuilder repo.
Signed-off-by: Manabu McCloskey <[email protected]>
blakeromano
approved these changes
Jun 4, 2024
nimakaviani
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
LGTM.
I thought about Carlos's suggestion about moving the Argo CD App file in the directory of the given component but that makes it hard for the controller to identify the right content to upload to a git repository.
This should work well as a first step.
I'll add a chore to clean up the idpbuilder example directory and update the docs on how to utilize these reference implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving examples from idpbuilder.