Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossPlane Compositions Re-architecture #25

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

elamaran11
Copy link
Contributor

This PR is for CrossPlane Compositions Re-architecture.

Signed-off-by: Elamaran Shanmugam <[email protected]>
@elamaran11
Copy link
Contributor Author

@nimakaviani @nabuskey Please merge CrossPlane Integrations PR and this PR to make CrossPlane compositions rearchitecture work.

Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we make separate repos for TF and Crossplane again?

If we are removing all these, we need to remove the backstage template with Crossplane resources in ref impl too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just get rid of this and direct everything under the other repo if we are going this route.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea has been to keep the integration here. but allow for the development of packages to happen separately. reducing the heavy load on templates in one repo. it is good to have this repo as way to list all the add-ons to a stack but then if they really want to have some templates pulled in, they pull them from the dedicated repo.

we separate the Crossplane and TF stuff because it provides easier boundaries on the work and the interest of folks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should get rid of the compositions in this repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just get rid of the crossplane and TF integration folders entirely, then just reference the other repo in readme files? I just don't see why we want to have two different places to keep updating.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally the add-on folder shouldnt need any updating. it only will be for when a new controller (or stack) gets added. we have already been making good amount of changes to the backstage integration repo but the stacks repo hasnt been impacted. same will happen with Crossplane too. cleaning things up and pulling the legacy backstage templates out, we won't have anything else to do with the crossplane folder in this repo.

That said, lets revisit this again maybe during the community call this coming Tuesday to see if a better alternative exists.

Signed-off-by: Elamaran Shanmugam <[email protected]>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11
Copy link
Contributor Author

Thanks Nima. @nabuskey Pls merge this.

@nimakaviani nimakaviani merged commit ad630da into cnoe-io:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants