Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use known namespace #87

Merged
merged 1 commit into from
Nov 20, 2023
Merged

use known namespace #87

merged 1 commit into from
Nov 20, 2023

Conversation

nabuskey
Copy link
Collaborator

Instead of relying on install object's namespace, use the known namespace.

Ran into an issue where the gitea deployment object was not found because the install manifest does not define a namespace. We know where deployment should go, so let's look in that namespace.

Signed-off-by: Manabu Mccloskey <[email protected]>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit e4d72bc into cnoe-io:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants