install nginx out of band #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nimakaviani
commented
Nov 15, 2023
nimakaviani
commented
- remove embedded nginx installation
- add a new reconciler to deploy nginx resources
- use the same resources previously installed via argo
- wait for it to successfully deploy before proceeding
- fix minor issues
|
lining up the PRs to reduce review overload. This is required for the gitea server's ingress to be installed out of band and for the domain names to become available to the gitea client |
- remove embedded nginx installation - add a new reconciler to deploy nginx resources - use the same resources previously installed via argo - wait for it to successfully deploy before proceeding - fix minor issues Signed-off-by: Nima Kaviani <[email protected]>
nimakaviani
force-pushed
the
nginx-embedded-install
branch
from
592b636 to
1440d25
Compare
nabuskey
requested changes
Nov 15, 2023
jessesanford
approved these changes
Nov 15, 2023
Signed-off-by: Nima Kaviani <[email protected]>
nimakaviani
force-pushed
the
nginx-embedded-install
branch
from
03bbce0 to
631ffbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.