Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run go vet #70

Merged
merged 2 commits into from
Oct 27, 2023
Merged

run go vet #70

merged 2 commits into from
Oct 27, 2023

Conversation

nabuskey
Copy link
Collaborator

We need to make sure go vet is run before merge.

explcit conflict with kind test

Signed-off-by: Manabu Mccloskey <[email protected]>
@nabuskey
Copy link
Collaborator Author

nabuskey commented Oct 27, 2023

The only way I can get the tests to run successfully is by running them one by one because there is a hard requirement for these tests to have a container running with the same port. I can't guarantee which one runs first. I also can't guarantee container run requests will succeed even with wait conditions because they could both send requests at the same time.

I see four ways:

  1. Rework the controllers to use docker interfaces instead so we can use our implementation in tests.
  2. Use test containers.
  3. Make the tests run one by one like it is done currently in this PR. this is bad because it affects all tests and slow.
  4. Remove one of tests.

Signed-off-by: Manabu Mccloskey <[email protected]>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say it is fine to require the sequence for v0.1

we will do some major refactor in the next release

@nimakaviani nimakaviani merged commit 92be6f9 into cnoe-io:main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants