Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix git controller test #53

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix git controller test #53

merged 1 commit into from
Oct 24, 2023

Conversation

nabuskey
Copy link
Collaborator

fixes: #37

Built-in controllers don't run so we can just look at objects instead of waiting for a deployment to be ready.

@nabuskey
fix git controller test
978f476 
Signed-off-by: Manabu Mccloskey <[email protected]>
nimakaviani
nimakaviani approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 23e6f99 into cnoe-io:main Oct 24, 2023
1 of 2 checks passed
@nimakaviani nimakaviani added this to the v0.1 release milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimakaviani nimakaviani nimakaviani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1 release
Development

Successfully merging this pull request may close these issues.

Git server controller test does not include built-in controllers
2 participants
@nabuskey @nimakaviani