fix: e2e test by updating Secret output TemplateData #467
Conversation
Signed-off-by: punkwalker <[email protected]>
.goreleaser.yaml
Outdated
| @@ -5,7 +5,7 @@ before: | |||
| - go mod tidy | |||
| release: | |||
| # Mark nightly build as prerelease based on tag | |||
| prerelease: '{{ contains .Tag "-nightly" }}' | |||
| prerelease: auto | |||
There was a problem hiding this comment.
Earlier expression was not evaluating correctly and nightly releases were not marked as prerelease. So this is another way of achieving the same.
There was a problem hiding this comment.
Let's do this in another PR.
pkg/cmd/get/secrets.go
Outdated
| type TemplateData struct { | ||
| IsCore bool `json:"isCore"` | ||
| Name string `json:"name"` | ||
| Namespace string `json:"namespace"` | ||
| Username string `json:"username"` | ||
| Password string `json:"password"` | ||
| Data map[string]string `json:"data"` | ||
| } |
There was a problem hiding this comment.
Why are we duplicating fields from the secret struct? I thought this struct isn't used?
There was a problem hiding this comment.
We can use struct from entity package in that case.
There was a problem hiding this comment.
This struct isn't used anywhere now, correct? We should remove it.
| for i := range secs { | ||
| if secs[i].Name == name { | ||
| out.Password = secs[i].Data["password"] | ||
| out.Username = secs[i].Data["username"] | ||
| for _, sec := range secs { | ||
| if sec.Name == name { | ||
| out.Password = sec.Password | ||
| out.Username = sec.Username | ||
| break |
There was a problem hiding this comment.
We are probably unmarshaing to wrong type.
There was a problem hiding this comment.
I think it's the right type, the sec slice is made from TemplateData struct.
There was a problem hiding this comment.
Changed it, Now using Secret struct from entity package
Signed-off-by: punkwalker <[email protected]>
punkwalker
force-pushed
the
fix-e2e-test
branch
from
4fe11d8 to
89a5431
Compare
Signed-off-by: punkwalker <[email protected]>
No description provided.