-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command to list the custom packages #466
base: main
Are you sure you want to change the base?
Conversation
cmoulliard
commented
Dec 24, 2024
- New command to list the custom packages
- See: Add list package(s) command #465
Signed-off-by: cmoulliard <[email protected]>
Signed-off-by: cmoulliard <[email protected]>
Example of what the code produce now Custom packages added
What the command
|
…mPackages Signed-off-by: cmoulliard <[email protected]>
Signed-off-by: cmoulliard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add additional printer columns for the package type?
https://book.kubebuilder.io/reference/generating-crd#additional-printer-columns
https://github.com/cnoe-io/idpbuilder/blob/main/api/v1alpha1/custom_package_types.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge all structs in separate files into one file? Is the entity
package for types? If so, we should name the package as types
instead of entity
.
|
||
idpbuilderNamespace, err := getIDPNamespace(ctx, kubeClient) | ||
if err != nil { | ||
return fmt.Errorf("calculating idp namespace: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return fmt.Errorf("calculating idp namespace: %w", err) | |
return fmt.Errorf("getting namespace: %w", err) |
for _, name := range packages { | ||
cp, err := getPackageByName(ctx, kubeClient, idpbuilderNamespace, name) | ||
if err != nil { | ||
return fmt.Errorf("get custom package: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return fmt.Errorf("get custom package: %w", err) | |
return fmt.Errorf("getting custom package %s: %w", name, err) |