Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gitea and argocd #422

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update gitea and argocd #422

wants to merge 3 commits into from

Conversation

nimakaviani
Copy link
Contributor

@nimakaviani nimakaviani commented Oct 20, 2024 •
edited
Loading

gitea 1.22.0 -> 1.22.3
argocd 2.10.7 -> 2.12.4

fixes #407
fixes #408

@nimakaviani nimakaviani changed the title update gitea 1.22.0 -> 1.22.3 update gitea and argocd Oct 20, 2024
@nimakaviani
fix test
b2b2e6b 
Signed-off-by: Nima Kaviani <[email protected]>
@nabuskey
Copy link
Collaborator

I think I want to go with what we have for the v1.0.0 release. Our tests for core packages are weak. I am 80% sure upgrading them will be fine but I'd rather push out v1 first to be on the safe side since we have tested what we have extensively. https://github.com/cnoe-io/idpbuilder/milestone/3

@cmoulliard
Copy link
Contributor

I think I want to go with what we have for the v1.0.0 release.

I don't think that we are yet ready to release v1.0.0 and I would prefer that we release first 0.8 and 0.9 to review fully the documentation, the parameter (and their name) to be used for the idpbuilder commands, etc before to release v1.0.0

@nimakaviani
Copy link
Contributor Author

the version bumps are minor bumps anyway. I dont think the changes will impact end users in an unforeseen way.

@nabuskey
Copy link
Collaborator

I think I want to go with what we have for the v1.0.0 release.

I don't think that we are yet ready to release v1.0.0 and I would prefer that we release first 0.8 and 0.9 to review fully the documentation, the parameter (and their name) to be used for the idpbuilder commands, etc before to release v1.0.0

I'd rather get it out with what we have as far as features are concerned. I am not saying we release it now. We will need to update the documentation still. As far as flag names are considered, we can change them fairly easily and alias. I haven't gotten much complaints about flag names so far.

the version bumps are minor bumps anyway. I dont think the changes will impact end users in an unforeseen way.

I really hope so but I honestly have no idea if that's the case. We have e2e tests but they are very basic and I haven't had the time to review documentations for any breaking changes. Not all projects follow the semantic versioning. Looking at you TypeScript.

tapas4java
tapas4java approved these changes Oct 31, 2024
View reviewed changes
pkg/controllers/localbuild/argo_test.go
@@ -80,7 +80,7 @@ func TestGetK8sInstallResources(t *testing.T) {
t.Fatalf("GetK8sInstallResources() error: %v", err)
}

if len(objs) != 58 {
if len(objs) != 60 {
t.Fatalf("Expected 58 Argo Install Resources, got: %d", len(objs))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Msg we can update to 60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapas4java tapas4java tapas4java approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

udpate gitea version update argocd version
4 participants
@nimakaviani @nabuskey @cmoulliard @tapas4java