-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install gitea #39
install gitea #39
Conversation
5351de3
to
b4405df
Compare
Why do you install gitea as kubernetes resources and not using a Helm chart instead as I described in my issue #32 ? |
The values file was used in If we go down the route of installing gitea using the helm chart, we will have to either pull the helm go libraries in or create a dependency to helm, which I'd like to avoid. As we discussed in #5 handling of any package or tool outside the initial bootstrapping should be handed over to Argo Apps, which can then take care of helm or kustomize or any other package types. That's why I am hesitant to introduce helm as part of the bootstrapping mechanism. its a draft PR, so open to suggestions here. |
Why ? You are also today creating a hard dependency as you must maintain the ArgoCD YAML file able to install argocd as core component + controller tracking its installation while using helm go lib we could more easily install the core components (argo cd, vault, argo workflow, cert manager) before to delegate to ArgoCD the job to install the |
Ok. |
@nimakaviani Is this going to be ready for review soon? I would like to get Gittea integration going. |
We should reference the secret for the admin user credentials instead of directly using it in the pod template. See: https://gitea.com/gitea/helm-chart#admin-user This way other controllers can reference it and get the credentials to talk to Gitea api. This does mean we have to helm template then add another manifest for the secret, which is a bit annoying and may cause confusions among users. So we should document and warn. |
b4405df
to
88e9d64
Compare
For helm values, we will also need to specify endpoint domain and URLs. Otherwise, API responses from Gitea for anything referencing base url has the default values of For my local testing, I am using this, then port-forward. gitea:
admin:
existingSecret: gitea-admin-secret
config:
database:
DB_TYPE: sqlite3
session:
PROVIDER: memory
cache:
ADAPTER: memory
queue:
TYPE: level
server:
DOMAIN: localtest.me
ROOT_URL: 'http://localtest.me:3000' |
88e9d64
to
e7456a7
Compare
- generalize installation for all embedded resources - enable blocking on verification - use secrets and https for gitea deployment Signed-off-by: Nima Kaviani <[email protected]>
e7456a7
to
55c3130
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Thanks for drying up those local installs.
) | ||
|
||
//go:embed resources/nginx/k8s/* | ||
var installNginxFS embed.FS | ||
var timeout = time.After(3 * time.Minute) | ||
|
||
func RawNginxInstallResources() ([][]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the ability to get embedded resources outside of these packages? Keep the functions or export the variable. The git repository reconciler needs a way to retrieve these to sync with gittea repos. You don't have to pass local dir ref and we have a distinction between repositories created with embedded contents vs local directory.
apiVersion: idpbuilder.cnoe.io/v1alpha1
kind: GitRepository
metadata:
name: argocd
namespace: default
spec:
giteaURL: "http://localhost:3000"
source:
embeddedAppName: "argocd"
type: embedded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets revisit it as part of pushing the files to the repos in the next PR. We will make adjustments where needed and when needed.
Signed-off-by: Nima Kaviani <[email protected]>
fixes 32