Updated K8s version #384
Updated K8s version #384
Conversation
|
@nabuskey could you please review this PR! |
|
@AryanSharma9917 Looks like it's not building correctly. Would you please take a look? https://github.com/cnoe-io/idpbuilder/actions/runs/10776701846/job/29884087640?pr=384 |
|
@AryanSharma9917 Any progress on this? I'd like to do this before cutting the next release. |
Signed-off-by: AryanSharma9917 <[email protected]> Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
Signed-off-by: Aryan Sharma <[email protected]>
AryanSharma9917
force-pushed
the
api-version
branch
from
3b7cc89 to
110e4a3
Compare
|
@nabuskey could you please look into it? |
go.mod
Outdated
| k8s.io/api v0.31.0 | ||
| k8s.io/apiextensions-apiserver v0.31.0 | ||
| k8s.io/apimachinery v0.31.0 | ||
| k8s.io/client-go v0.31.0 | ||
| k8s.io/klog/v2 v2.130.1 | ||
| sigs.k8s.io/controller-runtime v0.19.0 |
There was a problem hiding this comment.
I think we want v0.30, not v0.31. Controller-runtime should be 18.5. It's likely fine to have different versions but I'd like to keep the ArgoCD api and this repository in sync.
There was a problem hiding this comment.
@AryanSharma9917 Any update on this? It's been a while since we released idpbuilder version and we implemented some QOL changes so I'd like to release one soon. Let me know if you have any questions.
There was a problem hiding this comment.
@AryanSharma9917 Can you set the version to 0.30.0 here or 0.30.1 in the argocd api library? It's set as 0.30.0 in the argocd api here: https://github.com/cnoe-io/argocd-api/blob/main/go.mod. I'd really like them to be in sync.
There was a problem hiding this comment.
This PR is outdated as argocd go.mod points now to the version k8s.io/api v0.30.5
Signed-off-by: Aryan Sharma <[email protected]>
PR Title:
Update Kubernetes dependencies to v0.30.0
Description:
This PR updates the following Kubernetes dependencies to v0.30.0 to align with the latest K8s v1.30 release:
k8s.io/apifrom v0.29.1 to v0.30.0k8s.io/apiextensions-apiserverfrom v0.29.1 to v0.30.0k8s.io/apimachineryfrom v0.29.1 to v0.30.0k8s.io/client-gofrom v0.29.1 to v0.30.0These updates are necessary to leverage the latest Kubernetes features and improvements, ensure compatibility with the Kubernetes v1.30 cluster, and maintain stability and security in our project.
Related Issue:
Resolves #260
Checklist:
go.modandgo.sumfiles.