Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use kind labels field #376

Merged
merged 2 commits into from
Aug 29, 2024
Merged

use kind labels field #376

merged 2 commits into from
Aug 29, 2024

Conversation

nabuskey
Copy link
Collaborator

fixes: #374

Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani
Copy link
Contributor

you missed DCO it seems

Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey nabuskey merged commit eab34d6 into cnoe-io:main Aug 29, 2024
5 checks passed
@nabuskey nabuskey deleted the ingress-label branch August 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the default kind cluster config for ingress-nginx label
2 participants