-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logging format #370
Conversation
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
34a51c2
to
de68ef6
Compare
Don't forget to document how to enable/disable the colored output ;-) |
Yep. Plan is to make an issue to track it if this gets merged :) |
Any problem if we make colored output default to |
Coloring is very subjective and I didn't want to impose what I like to others by default. If others like it over time, we can make it enabled by default imo. |
Signed-off-by: Manabu McCloskey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, log outputs are hard to read. For example:
There is a lot of repeated texts that adds no value.
With this PR log messages look like:
This also adds colored output option. Disabled by default.