Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip refresh if owned by app set #354

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

nabuskey
Copy link
Collaborator

@nabuskey nabuskey commented Aug 5, 2024

On exit, we currently refresh ALL ArgoCD Applications. If applications are owned by application sets, we should not refresh them ourselves. Let ApplicationSets refresh instead.

Signed-off-by: Manabu McCloskey <[email protected]>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit a22d504 into cnoe-io:main Aug 5, 2024
5 checks passed
@nabuskey nabuskey deleted the selective-refresh branch August 6, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants