use self-signed cert for argocd server #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manabu McCloskey <[email protected]>
jessesanford
approved these changes
Aug 3, 2024
| @@ -25,12 +25,32 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| certificateOrgName = "cnoe.io" | |||
| certificateOrgName = "cnoe.io" | |||
| certificateValidLength = time.Hour * 8766 | |||
There was a problem hiding this comment.
Not really a big deal, but maybe we could shorten this? I feel like folks will not be keeping builder clusters up for more than weeks, but just in case we should flag the need to rotate these carts sooner?
There was a problem hiding this comment.
Yeah we can shorten it. Will follow up with another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ArgoCD does not use our cert. This PR changes that. This allows services that want to communicate with ArgoCD to do so without disabling TLS verification all together (still need to import the cert).