-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idpbuilder workflow Diagram #347
base: main
Are you sure you want to change the base?
Conversation
I can't quite figure out how to update the commit with the DCO. I am using the UI just because this is a minor change and appended the Sign-off-by to my message but it didnt work. Should I be doing something else? |
You can rebase this branch interactively and add the -s switch to your rebased commit. It will rewrite all your commits on this branch, but that shouldn't matter much since you are the only one working on it. Then force push to your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did a terrible job describing how it works and what I expected in the issue. Here's a rough sketch of how things work. Mermaid is definitely the way to go though.
As for DCO, you can usually just squash and/or rebase with sign off. For example:
Squash:
git rebase --signoff -i upstream/main
Or just signoff
git rebase --signoff upstream/main
|
||
```mermaid | ||
flowchart TD | ||
subgraph MainCluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "Target Cluster".
end | ||
|
||
CorePackages[Core Packages: \nArgoCD, \nGitea, \nIngress-nginx] | ||
LocalDir[Local Directory: \n- argocd-app.yaml \n- manifest files] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can specify remote repository as well in the -p flag.
ping @Bnjoroge1 |
This PR adds a workflow diagram for Idpbuilder to make it easy for us and new contributors to understand how everything works. Would love some feedback as I am fairly new to idpbuilder and the space as a whole.
I also did not include Backstage, and Crossplane as I don't believe they are installed by default. Please correct me if I'm wrong about this.