Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use right assert #346

Merged
merged 1 commit into from
Jul 30, 2024
Merged

use right assert #346

merged 1 commit into from
Jul 30, 2024

Conversation

nabuskey
Copy link
Collaborator

I was using the wrong assert library.

@nabuskey
use right assert
cb7755e 
Signed-off-by: Manabu McCloskey <[email protected]>
nimakaviani
nimakaviani approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 632490d into cnoe-io:main Jul 30, 2024
5 checks passed
@nabuskey nabuskey deleted the use-testify-assert branch July 31, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimakaviani nimakaviani nimakaviani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabuskey @nimakaviani