Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure latest stable version is downloaded #332

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nabuskey
Copy link
Collaborator

@nabuskey nabuskey commented Jul 5, 2024

Right now, the install script and the install instructions downloads the latest nightly release. This is not what we want. We want users to use the latest stable version.

Currently:

version=$(curl -Ls -o /dev/null -w %{url_effective} https://github.com/cnoe-io/idpbuilder/releases/latest)
version=${version##*/}
echo $version
v0.6.0-nightly.20240705 

With this PR:

version=$(curl -s https://api.github.com/repos/cnoe-io/idpbuilder/releases | grep tag_name | grep -o -e '"v[0-9].[0-9].[0-9]"' | head -n1 | sed 's/"//g')
echo $version
v0.5.0

@nabuskey nabuskey requested a review from a team as a code owner July 5, 2024 17:04
@nabuskey nabuskey requested a review from a team July 5, 2024 17:05
Copy link
Contributor

@omrishiv omrishiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nabuskey nabuskey merged commit dd3b226 into cnoe-io:main Jul 8, 2024
5 checks passed
@nabuskey nabuskey deleted the fix-install-script branch July 8, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants