Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service and ingress resources #33

Closed
wants to merge 3 commits into from
Closed

Conversation

cmoulliard
Copy link
Contributor

Remarks:

  • The UI reports as error Fail to load entity kinds when we navigate to https://backstage.idpbuilder.cnoe.io.local:8443/catalog. This problem is most probably due to cors badly defined as described here: 🐛 Bug Report: Failed to load entity kinds backstage/backstage#15403
  • If later, we also deploy cert manager, then we could add an annotation to the ingress resource to get the TLS secret populated by the cert manager

…ce to expose backstage using the host: backstage.idpbuilder.cnoe.io.local

Signed-off-by: cmoulliard <[email protected]>
@@ -116,17 +152,17 @@ data:
app-config.yaml: |
app:
title: CNOE
baseUrl: http://localhost:3000
baseUrl: "https://backstage.idpbuilder.cnoe.io.local:8443"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These needs to be either local.me or local.cnoe.io, depending on which one we use in #29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to change all the URLs (including what we have here + documentation when a PR will be created to fix issue 29

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - we're going to hopefully merge #29 asap which does this, we should change it here assuming we merge that one first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the DNS name to use cnoe.io.localtest.me @greghaynes

@cmoulliard
Copy link
Contributor Author

As you merged my commits in another PR, I will then close this PR @jessesanford Next time, we should keep my PR and not creating another one ;-)

@cmoulliard cmoulliard closed this Oct 19, 2023
@cmoulliard cmoulliard deleted the issue-22 branch October 19, 2023 06:45
@jessesanford
Copy link
Contributor

jessesanford commented Oct 19, 2023

As you merged my commits in another PR, I will then close this PR @jessesanford Next time, we should keep my PR and not creating another one ;-)

Hey sorry for merging your work without you online. I was creating the same code changes to fix backstage. Unfortunately I could not rebase your fork. Sorry for pulling the branch here in order to do so, all of your commits and the credit was attributed to you. In fact the full PR was taken in its complete state in order to retain your intent. If the PR was not ready for merge just mark it as WIP or draft or "don't merge". However I tested it and it was nearly exactly the code that I had prepared to commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants