-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service and ingress resources #33
Conversation
…ce to expose backstage using the host: backstage.idpbuilder.cnoe.io.local Signed-off-by: cmoulliard <[email protected]>
…local:8443 to avoid the error: backstage/backstage#15403 Signed-off-by: cmoulliard <[email protected]>
pkg/apps/srv/backstage/install.yaml
Outdated
@@ -116,17 +152,17 @@ data: | |||
app-config.yaml: | | |||
app: | |||
title: CNOE | |||
baseUrl: http://localhost:3000 | |||
baseUrl: "https://backstage.idpbuilder.cnoe.io.local:8443" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These needs to be either local.me
or local.cnoe.io
, depending on which one we use in #29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change all the URLs (including what we have here + documentation when a PR will be created to fix issue 29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - we're going to hopefully merge #29 asap which does this, we should change it here assuming we merge that one first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the DNS name to use cnoe.io.localtest.me @greghaynes
Signed-off-by: cmoulliard <[email protected]>
As you merged my commits in another PR, I will then close this PR @jessesanford Next time, we should keep my PR and not creating another one ;-) |
Hey sorry for merging your work without you online. I was creating the same code changes to fix backstage. Unfortunately I could not rebase your fork. Sorry for pulling the branch here in order to do so, all of your commits and the credit was attributed to you. In fact the full PR was taken in its complete state in order to retain your intent. If the PR was not ready for merge just mark it as WIP or draft or "don't merge". However I tested it and it was nearly exactly the code that I had prepared to commit. |
https://backstage.idpbuilder.cnoe.io.local:8443
Remarks:
Fail to load entity kinds
when we navigate tohttps://backstage.idpbuilder.cnoe.io.local:8443/catalog
. This problem is most probably due to cors badly defined as described here: 🐛 Bug Report: Failed to load entity kinds backstage/backstage#15403