-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure core package customizations are processed #307
Conversation
Signed-off-by: Manabu McCloskey <[email protected]>
ffa6c94
to
65f561d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't really see much documentation around how this feature is supposed to be invoked/used...
Is this a CLI argument to idpbuilder create
?
description: FilePath is the absolute file path to a YAML | ||
file that contains Kubernetes manifests. | ||
type: string | ||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this an enum?
description: PackageCustomization defines how packages are customized | ||
properties: | ||
filePath: | ||
description: FilePath is the absolute file path to a YAML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plan to not support helm or kustomize?
Good catch on the labels @nabuskey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We do need to do a better job of documenting these. |
fixes: #298
One thing to note when overwriting argocd CMs is that you need to have the labels on the CM. Otherwise, ArgoCD will complain about not finding
argocd-cm
CM.@csantanapr ^^