Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure core package customizations are processed #307

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

nabuskey
Copy link
Collaborator

@nabuskey nabuskey commented Jun 17, 2024

fixes: #298

One thing to note when overwriting argocd CMs is that you need to have the labels on the CM. Otherwise, ArgoCD will complain about not finding argocd-cm CM.

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
  labels: # these labels need to be present.
    app.kubernetes.io/name: argocd-cm 
    app.kubernetes.io/part-of: argocd
data:
  application.resourceTrackingMethod: annotation
  resource.exclusions: |
    - kinds:
        - ProviderConfigUsage
      apiGroups:
        - "*"
  timeout.reconciliation: 10s

@csantanapr ^^

@nabuskey nabuskey force-pushed the fix/package-custom branch from ffa6c94 to 65f561d Compare June 17, 2024 18:08
@nimakaviani nimakaviani self-requested a review June 17, 2024 18:12
Copy link
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't really see much documentation around how this feature is supposed to be invoked/used...

Is this a CLI argument to idpbuilder create?

description: FilePath is the absolute file path to a YAML
file that contains Kubernetes manifests.
type: string
name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this an enum?

description: PackageCustomization defines how packages are customized
properties:
filePath:
description: FilePath is the absolute file path to a YAML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plan to not support helm or kustomize?

@csantanapr
Copy link
Contributor

Good catch on the labels @nabuskey

Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nimakaviani nimakaviani merged commit e62c997 into cnoe-io:main Jun 17, 2024
3 checks passed
@nabuskey
Copy link
Collaborator Author

I also don't really see much documentation around how this feature is supposed to be invoked/used...

Is this a CLI argument to idpbuilder create?

We do need to do a better job of documenting these.
See: #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: can't override argocd config settings with idpbuilder create -c argocd:argocd-cm.yaml
4 participants