Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for #282: added oci registry readme help text #302

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

jessesanford
Copy link
Contributor

No description provided.

@jessesanford jessesanford requested a review from nabuskey June 14, 2024 23:06
@omrishiv
Copy link
Contributor

omrishiv commented Jun 14, 2024

Awesome, thanks! Is it worth mentioning how to pull the image from the cluster? I assume we either need a service account with the docker credentials or create a .dockerconfig on the node?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@csantanapr
Copy link
Contributor

@omrishiv

Awesome, thanks! Is it worth mentioning how to pull the image from the cluster? I assume we either need a service account with the docker credentials or create a .dockerconfig on the node?

no need for pull secrets, the images are public read access

@omrishiv
Copy link
Contributor

Ah, thanks for the clarification. Maybe something to think about in the future, but good to know.

@nabuskey nabuskey added the bug Something isn't working label Jun 17, 2024
@jessesanford jessesanford force-pushed the gitea-oci-registry-help branch from 5798e0e to b35c830 Compare June 17, 2024 18:15
@jessesanford jessesanford requested a review from csantanapr June 17, 2024 18:22
@nabuskey nabuskey added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jun 17, 2024
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jesse Sanford <[email protected]>
@jessesanford jessesanford merged commit 283ae1b into cnoe-io:main Jun 17, 2024
3 checks passed
@jessesanford jessesanford deleted the gitea-oci-registry-help branch June 17, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants