Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use localtest.me suffix to resolve localhost #29

Merged
merged 1 commit into from
Oct 18, 2023
Merged

use localtest.me suffix to resolve localhost #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ This can be useful in several ways:

Kubernetes: `kubectl get pods`

Argo: Visit https://argocd.idpbuilder.cnoe.io.local:8443/
Argo: Visit https://argocd.idpbuilder.cnoe.io.localtest.me:8443/

Backstage: http://backstage.idpbuilder.cnoe.io.local/
Backstage: http://backstage.idpbuilder.cnoe.io.localtest.me/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs the port number here to connect to ingress-nginx

 http://backstage.idpbuilder.cnoe.io.localtest.me:8443

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes as the we expose on the kind cluster and docker the ports 8443 and 8880. Question: Why do you export on kind/docker such ports instead to keep the standards: 80 and 443 ?

Copy link
Contributor Author

@jessesanford jessesanford Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. My guess is that they were using high number ports to avoid needing to be a privileged user on some systems

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such ports should be configurable and defaulted within the kind config file to: 80, 443. I will open a separate issue about that


## Architecture

Expand Down
2 changes: 1 addition & 1 deletion pkg/apps/srv/argocd/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
spec:
ingressClassName: "nginx"
rules:
- host: argocd.idpbuilder.cnoe.io.local
- host: argocd.idpbuilder.cnoe.io.localtest.me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to use a so long DNS name *.idpbuilder.cnoe.io.localtest.me vs *.idpbuilder.localtest.me or even better *.idp.localtest.me ?

http:
paths:
- path: /
Expand Down
Loading