Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure only yaml files are processed #288

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nabuskey
Copy link
Collaborator

We should be looking at yaml files only when processing custom packages.

@nimakaviani
Copy link
Contributor

looks like there is a failing test that needs fixing

@nabuskey nabuskey force-pushed the fix/file-type-check branch from 0393081 to 2d2fba5 Compare June 11, 2024 16:08
@nabuskey
Copy link
Collaborator Author

@nimakaviani Fixed.

@nimakaviani nimakaviani self-requested a review June 11, 2024 17:07
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 5e4aca7 into cnoe-io:main Jun 11, 2024
3 checks passed
@nabuskey nabuskey deleted the fix/file-type-check branch June 12, 2024 02:03
@cmoulliard
Copy link
Contributor

Can you next time please create a ticket otherwise it is needed to look to the issues and/or PR to discover; bug fixed, enhancements, etc @nabuskey @nimakaviani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants