Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pipe to bash script #272

Merged
merged 4 commits into from
Jun 3, 2024
Merged

add pipe to bash script #272

merged 4 commits into from
Jun 3, 2024

Conversation

nimakaviani
Copy link
Contributor

also updates the README

@nimakaviani
add pipe to bash script
af08b36 
Signed-off-by: Nima Kaviani <[email protected]>
blakeromano
blakeromano reviewed Jun 3, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
blakeromano
blakeromano approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of typo 🚀

README.md Outdated Show resolved Hide resolved
@nimakaviani
fix the README msg
447dac5 
Signed-off-by: Nima Kaviani <[email protected]>
@nimakaviani
move to the bin folder
8f742f3 
Signed-off-by: Nima Kaviani <[email protected]>
omrishiv
omrishiv reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@omrishiv omrishiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but LGTM

README.md Outdated Show resolved Hide resolved
@nimakaviani
fix syntax
b9a0af8 
Signed-off-by: Nima Kaviani <[email protected]>
nabuskey
nabuskey approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabuskey nabuskey merged commit c5aa90c into main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omrishiv omrishiv omrishiv left review comments

@blakeromano blakeromano blakeromano approved these changes

@nabuskey nabuskey nabuskey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nimakaviani @omrishiv @nabuskey @blakeromano