Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git client timeouts #206

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

nabuskey
Copy link
Collaborator

Fixes an issue where TCP connection to the gitea server times out and the reconciler could not finish its job.

  • Adds go-git client timeout values for TCP and HTTP.
  • Clone repositories with context instead.

Signed-off-by: Manabu McCloskey <[email protected]>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix

@nimakaviani nimakaviani merged commit f60a780 into cnoe-io:main Apr 23, 2024
2 checks passed
@nabuskey nabuskey deleted the fix/git-timeout branch April 24, 2024 00:01
nimakaviani added a commit that referenced this pull request May 16, 2024
we fixed it for the gitCliet in #206 but same can occur
with the gitea client and this PR fixes it

Signed-off-by: Nima Kaviani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants