Enable gitea oci registry #166
Conversation
jessesanford
force-pushed
the
enable-gitea-oci-registry
branch
3 times, most recently
from
d32794c to
254d45c
Compare
jessesanford
changed the title
jessesanford
force-pushed
the
enable-gitea-oci-registry
branch
from
254d45c to
5b98d28
Compare
|
We had some discussions around enabling gitea OCI registry. I think we should enable it by default and let users decides to use it. My reasoning is that we already install Gitea by default so we can get this feature for "free". I don't see any harm in enabling this feature by default so long as we stay local. BUT we need to be careful and not rely on this. End users should be able to use whatever registries they want to use. We should not restrict them to using this registry. As for this particular patch, I am inclined to not use this patch. I would like to use the upstream version. The issue seems to be related to mismatched name resolution. Wonder if we can work around this with Core DNS config? |
|
@jessesanford can you plz drop the link to the change you had to make to gitea for its image registry to work? I am curious if we can find a better way to get around the problem than to have to use a custom image. |
|
@nabuskey I agree with everything you said. It just so happens this works very well with the ref-implementation workflows I am developing. @nimakaviani the unofficial PR for my changes is here... it's pretty simple: https://github.com/jessesanford/gitea/pull/1/files You can also see the discussion of the issue here on the official repo: go-gitea/gitea#29591 I am bullish on this becoming an actual upstream patch as the project has accepted similar contributions for the git repo functionality in the past. See: go-gitea/gitea#19345 |
|
How about adding Harbor as a core application and use as OCI/Image registry? Anyway every platform needs some kind of registry for application images |
|
@jessesanford 's PR to gitea got merged and we should be able to leverage gitea as the OCI registry as well. Need to update to the latest gitea version with the fix in it though. I will create an issue for it |
Signed-off-by: Jesse Sanford <[email protected]> update gitea to latest helm chart Signed-off-by: Jesse Sanford <[email protected]>
jessesanford
force-pushed
the
enable-gitea-oci-registry
branch
from
5b98d28 to
a5d1978
Compare
This is now working with the following patch for gitea: https://github.com/jessesanford/gitea/blob/c2fffabcd5122d258360d4443b6e583fc62e28f1/routers/api/packages/container/container.go#L119-L131
We need to decide if we want to use this forked version temporarily while we shape a PR for upstream or continue to use an additional registry. @nimakaviani @nabuskey @greghaynes wdyt?