Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default cluster version to 1.27 #131

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

nabuskey
Copy link
Collaborator

We use K8s version 1.27 in tests, while the default version in CLI is set at 1.26. We should use 1.27 for all.

1.27.3 was taking from Kind release that we use: https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0

@nabuskey nabuskey force-pushed the bump-default-cluster-version branch from b8232ce to 1307bc4 Compare January 23, 2024 19:32
Copy link
Contributor

@blakeromano blakeromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wonder if we should just go to 1.28?

@nabuskey
Copy link
Collaborator Author

We could. But our controller-runtime is a bit old and technically they are not compatible as-is. 1.27 seems ok from my testing. I think I am more inclined to upgrade to 1.28 once we have the controller-runtime dependencies figured out.

@blakeromano
Copy link
Contributor

We could. But our controller-runtime is a bit old and technically they are not compatible as-is. 1.27 seems ok from my testing. I think I am more inclined to upgrade to 1.28 once we have the controller-runtime dependencies figured out.

I think as long as that is apart of the controller-runtime dependency work then that sounds fine!

@cmoulliard
Copy link
Contributor

Is it documented on the README.md that idpbuilder should be deployed on kind >= 1.27 since release 0.x ?
@nabuskey

@greghaynes
Copy link
Contributor

Lets just merge this - I dont think theres a user facing version dependency here we need to worry about documenting since we vendor our kind dep. If a user has a different kind version IME it "just works".

@greghaynes greghaynes merged commit 92a7440 into cnoe-io:main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants