-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for logging customization #130
Conversation
Ideally we should use the new go logger - #15 (comment) ;-) @nabuskey |
I know. I was trying to use slog first but our controller-runtime is too old and doesn't come with a version of logr that supports slog. #95 needs to be resolved first. At least this PR makes it possible to change logging configuration... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
if we pull in the new Argo types repo that @greghaynes created, shall we be able to update controller-runtime and use the newer logr instead?
Yes. We should be able to do that. |
4512a58
to
24c7435
Compare
This PR now uses slog as the underlying logging implementation for controllers. |
That looks better using
Remarks - see: #15 (comment):
|
Let's worry about formats and coloring and what not later. Like I mentioned, this is meant to allow for actual customization of logs. Right now, we have NO control over log levels or formats. |
Can we make a good-first-issue for improving this logging as we mention? I think this PR is good to merge as is, but I'd like to not lose that issue if possible. |
Signed-off-by: Manabu McCloskey <[email protected]>
As mentioned in #15, currently it's not possible to configure logging format or level.
This PR ensures logging customization work and implements our own defaults: RFC3339 timestamps and console logs.
Uses slog as the underlying implementation.