use annotation tracking by default #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manabu McCloskey <[email protected]>
cmoulliard
reviewed
Jan 2, 2024
Signed-off-by: Manabu Mccloskey <[email protected]>
|
@cmoulliard Good idea. Reflected it in the README. |
cmoulliard
approved these changes
Jan 3, 2024
jessesanford
approved these changes
Jan 5, 2024
README.md
Outdated
| ArgoCD manifests are generated using a bash script available [here](./hack/argo-cd/generate-manifests.sh). | ||
| This script runs kustomize to modify the basic installation manifests provided by ArgoCD. Modifications include: | ||
|
|
||
| 1. Prevent notificaiton and dex pods from running. This is done to keep the number of pods running low by default. |
There was a problem hiding this comment.
/notificaition/notification/
Signed-off-by: Manabu Mccloskey <[email protected]>
nabuskey
force-pushed
the
use-annotation-tracking
branch
from
8c4ba83 to
6d76d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation tracking method is a must when using Crossplane with ArgoCD. This PR enables it.
https://argo-cd.readthedocs.io/en/stable/user-guide/resource_tracking/#additional-tracking-methods-via-an-annotation