ensure multi source spec is handled #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manabu McCloskey <[email protected]>
cmoulliard
reviewed
Jan 2, 2024
Comment on lines
11
to
13
| - repoURL: cnoe://busybox | ||
| targetRevision: HEAD | ||
| path: "." |
There was a problem hiding this comment.
Sorry if I missed something but this test case only includes one source and not (as title mentions) several sources !
There was a problem hiding this comment.
Yeah it's meant to represent a case when the sources field is used. Which is not exactly the same as what is described in the title. I'll update the test.
Signed-off-by: Manabu Mccloskey <[email protected]>
nabuskey
force-pushed
the
fix/multi-source
branch
from
54f86d0 to
29d1e3f
Compare
|
Updated it to further handle a case where the same directory is specified twice in the spec. This is a valid configuration since you can specify the path parameter to distinguish the two. spec:
sources:
- repoURL: cnoe://app2
targetRevision: HEAD
path: "one"
- repoURL: cnoe://app2
targetRevision: HEAD
path: "two" |
cmoulliard
approved these changes
Jan 3, 2024
jessesanford
approved these changes
Jan 5, 2024
| @@ -190,8 +190,13 @@ func (r *Reconciler) reconcileGitRepo(ctx context.Context, resource *v1alpha1.Cu | |||
| } | |||
| return nil | |||
| }) | |||
| // it's possible for an application to specify the same directory multiple times in the spec. | |||
| // if there is a repository already created for this package, no further action is necessary. | |||
| if !errors.IsAlreadyExists(err) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when you are using multi sources in ArgoCD, the repo url was not updated correctly. It was because we were not updating the correct object.