Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localbuild): scale down dex and notifications pods for argo cd #122

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Dec 17, 2023

Fixes #86. Scale down the dex-server and notifications-controller deployments to zero pods to save on resources.

Each commit is atomic, so for a precise review, look at each one.

To maintain the install.yaml file, a script and a kustomization have been added to generate the contents. You can re-generate it from the root of the project with:

./hack/argo-cd/generate-manifests.sh

The unrelated changes to the install.yaml come from the difference between when it was originally generated from master to from a tagged release (v2.8.7).

Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this!

@nabuskey nabuskey merged commit ad688d4 into cnoe-io:main Dec 18, 2023
2 checks passed
@morey-tech morey-tech deleted the remove-argocd-pods branch December 18, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing unnecessary ArgoCD pods
2 participants