-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom packages #100
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e81f85c
allow for custom packages to be installed
nabuskey 9f83544
custom package root type
nabuskey 9054d09
fix tests, ensure internal repo urls are passed
nabuskey 23dd352
clean up comments
nabuskey 1aa1601
re-generate manifest
nabuskey 73b7fe8
custom packages are optional
nabuskey 43d4b79
explicit default value for the replicate field
nabuskey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package v1alpha1 | ||
|
||
import ( | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
// +kubebuilder:object:root=true | ||
// +kubebuilder:subresource:status | ||
type CustomPackage struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec CustomPackageSpec `json:"spec,omitempty"` | ||
Status CustomPackageStatus `json:"status,omitempty"` | ||
} | ||
|
||
// +kubebuilder:object:root=true | ||
type CustomPackageList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []CustomPackage `json:"items"` | ||
} | ||
|
||
// CustomPackageSpec controls the installation of the custom applications. | ||
type CustomPackageSpec struct { | ||
// Replicate specifies whether to replicate remote or local contents to the local gitea server. | ||
// +kubebuilder:default:=false | ||
Replicate bool `json:"replicate"` | ||
// GitServerURL specifies the base URL for the git server for API calls. | ||
// for example, http://gitea.cnoe.localtest.me:8880 | ||
GitServerURL string `json:"gitServerURL"` | ||
// InternalGitServeURL specifies the base URL for the git server accessible within the cluster. | ||
// for example, http://my-gitea-http.gitea.svc.cluster.local:3000 | ||
InternalGitServeURL string `json:"internalGitServeURL"` | ||
GitServerAuthSecretRef SecretReference `json:"gitServerAuthSecretRef"` | ||
|
||
ArgoCD ArgoCDPackageSpec `json:"argoCD,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
type ArgoCDPackageSpec struct { | ||
// ApplicationFile specifies the absolute path to the ArgoCD application file | ||
ApplicationFile string `json:"applicationFile"` | ||
Name string `json:"name"` | ||
Namespace string `json:"namespace"` | ||
} | ||
|
||
type CustomPackageStatus struct { | ||
Synced bool `json:"synced,omitempty"` | ||
GitRepositoryRefs []ObjectRef `json:"gitRepositoryRefs,omitempty"` | ||
} | ||
|
||
type ObjectRef struct { | ||
APIVersion string `json:"apiVersion,omitempty"` | ||
Name string `json:"name,omitempty"` | ||
Namespace string `json:"namespace,omitempty"` | ||
Kind string `json:"kind,omitempty"` | ||
UID string `json:"uid,omitempty"` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be defaulted to something, no? I assume it is probably a
no
by default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it defaults to false via zero value. I'll add an annotation to be explicit.