Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s to 1.30 #260

Closed
3 of 6 tasks
nabuskey opened this issue May 16, 2024 · 4 comments · Fixed by #429 · May be fixed by #384
Closed
3 of 6 tasks

Update k8s to 1.30 #260

nabuskey opened this issue May 16, 2024 · 4 comments · Fixed by #429 · May be fixed by #384
Milestone
v1.0.0

Comments

@nabuskey
Copy link
Collaborator

nabuskey commented May 16, 2024 •
edited
Loading

Not urgent.
@nabuskey nabuskey changed the title update controller-runtime to 1.30 update k8s to 1.30 May 16, 2024
@nabuskey nabuskey changed the title update k8s to 1.30 Update k8s to 1.30 May 16, 2024
@AryanSharma9917
Copy link
Contributor

Hey @nabuskey, can I work on these issues?

@nabuskey
Copy link
Collaborator Author

Yes! I think argocd api should be updated first before anything. https://github.com/cnoe-io/argocd-api/blob/main/go.mod

@AryanSharma9917
Copy link
Contributor

Yes! I think argocd api should be updated first before anything. https://github.com/cnoe-io/argocd-api/blob/main/go.mod

Hi @nabuskey , just to confirm: I'll update the Go version in go.mod to go 1.22, bump the Kubernetes dependencies (k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/apimachinery, k8s.io/client-go) to v0.30.0, update sigs.k8s.io/controller-runtime to v0.17.1, and change ENVTEST_K8S_VERSION in the Makefile to 1.30.0. Afterward, I'll run go mod tidy. Does this look good?

@AryanSharma9917 AryanSharma9917 mentioned this issue Aug 25, 2024
Merged
@nabuskey
Copy link
Collaborator Author

Hi @nabuskey , just to confirm: I'll update the Go version in go.mod to go 1.22, bump the Kubernetes dependencies (k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/apimachinery, k8s.io/client-go) to v0.30.0, update sigs.k8s.io/controller-runtime to v0.17.1, and change ENVTEST_K8S_VERSION in the Makefile to 1.30.0. Afterward, I'll run go mod tidy. Does this look good?

Yes that makes sense to me. Couple more things we should do that I just noticed:

Thanks again for working on this!

@AryanSharma9917 AryanSharma9917 mentioned this issue Aug 27, 2024
Merged
@AryanSharma9917 AryanSharma9917 mentioned this issue Sep 9, 2024
Open
3 tasks
@nabuskey nabuskey added this to the v1.0.0 milestone Oct 15, 2024
@nabuskey nabuskey mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

bump to k8s 0.30.5 nabuskey/idpbuilder
Updated K8s version AryanSharma9917/idpbuilder
2 participants
@nabuskey @AryanSharma9917