Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Command CNOE Custom plugin #38

Closed
wants to merge 2 commits into from

Conversation

mmaroth
Copy link
Contributor

@mmaroth mmaroth commented Sep 18, 2024

We have requirement to run shell commands as part of scaffolder plugin, currently we dont have action available out of the box to run commands, so we are extending cnoe backstage app to have custom command execution action as part of scaffolder backend plugin.

Added Execute command

Signed-off-by: Mani Marothu <[email protected]>
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I want to allow template authors to have control over the pod and instance by allowing them to run arbitrary commands. If there's a task or tasks to be executed, we should define them in the actions instead.

@mmaroth
Copy link
Contributor Author

mmaroth commented Sep 24, 2024

I'm closing this PR as it allows users to run any commands on backstages.

@mmaroth mmaroth closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants