Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add application set #2

Merged
merged 1 commit into from
May 30, 2024
Merged

add application set #2

merged 1 commit into from
May 30, 2024

Conversation

nabuskey
Copy link
Contributor

@nabuskey nabuskey commented May 30, 2024

Adds application set types. The main objective is to support application sets for idpbuilder.

I noticed we have dependencies on logrus and grpc stuff. I think it's safe to remove these since we don't really care about functions defined in types. Maybe in another PR.

Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey nabuskey requested a review from greghaynes May 30, 2024 20:30
@nabuskey nabuskey mentioned this pull request May 30, 2024
2 tasks
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 91a5bf0 into main May 30, 2024
1 check passed
@nabuskey nabuskey deleted the app-set branch May 30, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants