chore(refactor): prefer path.resolve (angular#3751)

`path.join` does not account for absolute paths like `path.resolve` does. This is not a problem in this case but could be in the future
cnishina · Nov 18, 2016 · 70bc6ea · 70bc6ea
1 parent 40eb493
commit 70bc6ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/cli.ts b/lib/cli.ts
@@ -80,7 +80,7 @@ if (argv.help) {
 }
 
 if (argv.version) {
-  console.log('Version ' + require(path.join(__dirname, '../package.json')).version);
+  console.log('Version ' + require(path.resolve(__dirname, '../package.json')).version);
   process.exit(0);
 }
 

diff --git a/testapp/scripts/web-server.js b/testapp/scripts/web-server.js
@@ -10,15 +10,15 @@ var env = require('../../spec/environment.js');
 var testApp = express();
 var DEFAULT_PORT = process.env.HTTP_PORT || env.webServerDefaultPort;
 var testAppDir = path.resolve(__dirname, '..');
-var defaultAngular = require(path.join(testAppDir, 'ng1/lib/angular_version.js'));
+var defaultAngular = require(path.resolve(testAppDir, 'ng1/lib/angular_version.js'));
 
 var argv = optimist.describe('port', 'port').
     default('port', DEFAULT_PORT).
     describe('ngversion', 'version of AngularJS to use').
     default('ngversion', defaultAngular).
     argv;
 
-var angularDir = path.join(testAppDir, 'ng1/lib/angular_v' + argv.ngversion);
+var angularDir = path.resolve(testAppDir, 'ng1/lib/angular_v' + argv.ngversion);
 
 var main = function() {
   var port = argv.port;