-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generating python proto code #110
base: main
Are you sure you want to change the base?
Conversation
3ca3253
to
5394619
Compare
Signed-off-by: Kunjan Patel <[email protected]> Signed-off-by: Kunjan Patel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In addition to the comments, a high-level question: are the __init__.py
files auto generated? (I'm assume the bazel command adds these, but just want to make sure).
python/setup.py
Outdated
packages=find_packages(), | ||
install_requires=[ | ||
'protobuf==5.29.1', | ||
'protoc-gen-validate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what version we should have? what version is being used for go?
…e. Add disrtribution wheel Signed-off-by: Kunjan Patel <[email protected]>
…e. Add disrtribution wheel Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Changes in the following PR