Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating python proto code #110

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

coolkp
Copy link

@coolkp coolkp commented Dec 18, 2024

Changes in the following PR

  • Updated protoc version
  • Generate go code only has new protoc version
  • Update generate_go_protobuf -> generate_protobuf to add python code generation
  • Generated Python code
  • Package generated python code as pip package

@coolkp coolkp force-pushed the main branch 2 times, most recently from 3ca3253 to 5394619 Compare December 18, 2024 22:52
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
@coolkp coolkp marked this pull request as ready for review December 20, 2024 19:03
Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
In addition to the comments, a high-level question: are the __init__.py files auto generated? (I'm assume the bazel command adds these, but just want to make sure).

python/setup.py Outdated
packages=find_packages(),
install_requires=[
'protobuf==5.29.1',
'protoc-gen-validate',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what version we should have? what version is being used for go?

python/setup.py Outdated Show resolved Hide resolved
tools/generate_protobuf.py Outdated Show resolved Hide resolved
tools/generate_protobuf.py Outdated Show resolved Hide resolved
tools/generate_protobuf.py Outdated Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
python/LICENSE Outdated Show resolved Hide resolved
coolkp added 4 commits January 8, 2025 01:59
…e. Add disrtribution wheel

Signed-off-by: Kunjan Patel <[email protected]>
…e. Add disrtribution wheel

Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants