udpa: add core proto definitions from xDS transport++ proposal. #29
Conversation
These are the new UDPA protos from envoyproxy/envoy#11264 and https://docs.google.com/document/d/1zZav-IYxMO0mP2A7y5XHBa9v0eXyirw1CxrLLSUqWR8/edit. Signed-off-by: Harvey Tuch <[email protected]>
|
CC @markdroth @louiscryan @howardjohn @costinm This objective of this patch is to land a viable base set of definitions to work on from both the Envoy and Istio side. These are tagged WiP to allow arbitrary edits until we're happy with them. This PR won't be landing the full set of docs and UDPA spec, I'd prefer to wait until we've worked through some of the implementation details Envoy side to clarify that. |
| } | ||
| } | ||
|
|
||
| repeated Directive directives = 6; |
There was a problem hiding this comment.
Note that we still have an open thread on how this interacts with RFC3986 URIs with only a single #fragment in the design doc (@markdroth @louiscryan), see https://docs.google.com/document/d/1zZav-IYxMO0mP2A7y5XHBa9v0eXyirw1CxrLLSUqWR8/edit?disco=AAAAGpGgj2A.
There was a problem hiding this comment.
Yeah. As I mentioned there, I think we should remove the alt directive and the repeated here. Instead, we can use a repeated UdpaResourceLocator in the places in the API where we have forward-pointers.
| } | ||
| } | ||
|
|
||
| repeated Directive directives = 6; |
There was a problem hiding this comment.
Yeah. As I mentioned there, I think we should remove the alt directive and the repeated here. Instead, we can use a repeated UdpaResourceLocator in the places in the API where we have forward-pointers.
Signed-off-by: Harvey Tuch <[email protected]>
|
Re: alt vs repeated, I think let's merge as is and I will do a dedicated PR around this, this probably needs a bit of thought. |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
|
@mattklein123 can I get another rubber stamp on this? Thanks. |
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
These are the new UDPA protos from envoyproxy/envoy#11264
and
https://docs.google.com/document/d/1zZav-IYxMO0mP2A7y5XHBa9v0eXyirw1CxrLLSUqWR8/edit.
Signed-off-by: Harvey Tuch [email protected]