Cloud Native Security Whitepaper submitted #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't looked through content, since I know you are still working on it. Just wanted to make a couple of requests:
Thanks so much for your work on the conversion! We should pull in White Paper authors when it is ready for review. |
Signed-off-by: Ihor Dvoretskyi <[email protected]>
Signed-off-by: Ihor Dvoretskyi <[email protected]>
idvoretskyi
force-pushed
the
idvoretskyi-security-whitepaper
branch
from
ffa9858 to
f6e5933
Compare
|
@idvoretskyi a quick skim - everything looks in place. I made some alterations to the initial content in preparation for the upcoming post. |
Co-authored-by: Emily Fox <[email protected]>
Co-authored-by: Emily Fox <[email protected]>
|
@TheFoxAtWork thanks! |
Signed-off-by: Ihor Dvoretskyi <[email protected]>
…kyi/sig-security into idvoretskyi-security-whitepaper
PushkarJ
reviewed
Nov 13, 2020
PushkarJ
reviewed
Nov 13, 2020
PushkarJ
reviewed
Nov 13, 2020
| **Work-Group:** SIG-Security **Short self link to working doc:** https://tinyurl.com/CNCF-CNSWP | **Status** : WIP | In Review | **Approved** | Obsolete | ||
|
|
||
| **Created** : 2020-FEB-01 **Reviewed** : 2020-OCT-27 **Published** : 2020-NOV-18 **Release Version:** 1.0 **Approvers** : [x] @lizrice [x] @justincormack | | ||
| | **Contributors:** [[email protected]](mailto:[email protected]), [[email protected]](mailto:[email protected]), [[email protected]](mailto:[email protected]), [email protected] @lumjjb, @trishankatdatadog, [@[email protected]](mailto:[email protected]), @pushkarj-v, @whaber, @sublimino, @rowan-baker, [[email protected]](mailto:[email protected]), [[email protected]](mailto:[email protected]), [email protected] |
There was a problem hiding this comment.
@idvoretskyi : Had a recent change in my Github ID/username and the one here does not exist. Can you please replace @pushkarj-v with @pushkarj ? Thanks and sorry for the bother.
There was a problem hiding this comment.
Can we add links to the github IDs as well?
PushkarJ
reviewed
Nov 13, 2020
PushkarJ
reviewed
Nov 13, 2020
PushkarJ
reviewed
Nov 13, 2020
|
@idvoretskyi added a few comments, mostly nits. Thank you so much, for your excellent work :) |
|
@PushkarJ thanks a lot, will address them! |
Signed-off-by: Ihor Dvoretskyi <[email protected]>
idvoretskyi
requested review from
dshaw,
JustinCappos,
pragashj and
ultrasaurus
as code owners
TheFoxAtWork
approved these changes
Nov 17, 2020
Co-authored-by: Emily Fox <[email protected]>
lumjjb
reviewed
Nov 18, 2020
lumjjb
reviewed
Nov 18, 2020
Co-authored-by: Brandon Lum <[email protected]>
|
@TheFoxAtWork ping for the final review :) |
TheFoxAtWork
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
@lumjjb @pragashj @ultrasaurus @JustinCappos need a second approval on this to merge
Michael-Susu12138
pushed a commit
to Michael-Susu12138/tag-security
that referenced
this pull request
Dec 12, 2023
* Cloud Native Security Whitepaper submitted Signed-off-by: Ihor Dvoretskyi <[email protected]> * Cloud Native Security Whitepaper submitted Signed-off-by: Ihor Dvoretskyi <[email protected]> * Update security-whitepaper/cloud_native_security_whitepaper.md Co-authored-by: Emily Fox <[email protected]> * Update security-whitepaper/cloud_native_security_whitepaper.md Co-authored-by: Emily Fox <[email protected]> * MD File renamed Signed-off-by: Ihor Dvoretskyi <[email protected]> * Formatting fixes & comments addressed Signed-off-by: Ihor Dvoretskyi <[email protected]> * Apply suggestions from code review Co-authored-by: Emily Fox <[email protected]> * Apply suggestions from code review Co-authored-by: Brandon Lum <[email protected]> * Update security-whitepaper/cloud-native-security-whitepaper.md Co-authored-by: Emily Fox <[email protected]> Co-authored-by: Brandon Lum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ihor Dvoretskyi [email protected]