-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modifications to assessment docs per 06122019 meeting notes #207
Conversation
@ultrasaurus please take a look and ensure i include the areas discussed per last wednesday's meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! Thanks so much for all of your edits. Left a lot of comments, but mostly small things. Would like to hear from @JustinCappos on naming
- security assessment
- project security assessment
- CNCF project security assessment
- etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ultrasaurus Changes made and provided consisetncy in wrapping/breaks & headers/paragraphs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting nit: other pages I looked at did not have leading indent, so let's not modify to add that. I've added a bit to the (new) style guide to cover this: #214
Thanks for iterating on this!
…ecurity into assessment-doc-update
@ultrasaurus i believe i've caught everything we discussed |
@JustinCappos -- note that for naming, it seems we're going with:
which is good with me -- thanks @TheFoxAtWork for picking something and making the doc consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix the typo in assessments/README.md
before merging, naming consistency can be addressed in follow-up PR since this one is net positive :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
added @JustinCappos as reviewer for visibility, but since this PR contains clarifications to reflect the process we've actually been following, I will go ahead and merge |
modifications to assessment docs per 06122019 meeting notes
Made changes to existing assessment docs per discussion from 06122019 meeting notes. Opened new issue #206, commented on issue #183