Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications to assessment docs per 06122019 meeting notes #207

Merged
merged 20 commits into from
Jul 1, 2019

Conversation

TheFoxAtWork
Copy link
Contributor

Made changes to existing assessment docs per discussion from 06122019 meeting notes. Opened new issue #206, commented on issue #183

@TheFoxAtWork
Copy link
Contributor Author

@ultrasaurus please take a look and ensure i include the areas discussed per last wednesday's meeting

Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! Thanks so much for all of your edits. Left a lot of comments, but mostly small things. Would like to hear from @JustinCappos on naming

  • security assessment
  • project security assessment
  • CNCF project security assessment
  • etc

@ultrasaurus ultrasaurus added the question Further information is requested label Jun 18, 2019
Copy link
Contributor Author

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ultrasaurus Changes made and provided consisetncy in wrapping/breaks & headers/paragraphs

Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nit: other pages I looked at did not have leading indent, so let's not modify to add that. I've added a bit to the (new) style guide to cover this: #214

Thanks for iterating on this!

@TheFoxAtWork
Copy link
Contributor Author

@ultrasaurus i believe i've caught everything we discussed

@ultrasaurus
Copy link
Member

@JustinCappos -- note that for naming, it seems we're going with:

The CNCF security assessment, hereafter "security assessment,"

which is good with me -- thanks @TheFoxAtWork for picking something and making the doc consistent

@ultrasaurus ultrasaurus removed the question Further information is requested label Jul 1, 2019
Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the typo in assessments/README.md before merging, naming consistency can be addressed in follow-up PR since this one is net positive :)

@ultrasaurus ultrasaurus requested a review from JustinCappos July 1, 2019 15:16
Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ultrasaurus
Copy link
Member

added @JustinCappos as reviewer for visibility, but since this PR contains clarifications to reflect the process we've actually been following, I will go ahead and merge

@ultrasaurus ultrasaurus merged commit ae0a4fa into cncf:master Jul 1, 2019
@TheFoxAtWork TheFoxAtWork deleted the assessment-doc-update branch January 23, 2020 13:39
Michael-Susu12138 pushed a commit to Michael-Susu12138/tag-security that referenced this pull request Dec 12, 2023
modifications to assessment docs per 06122019 meeting notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants