Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: scope the sig-security presentations to the security model and let the assessor do the presentation? #162

Closed
ficcaglia opened this issue May 15, 2019 · 6 comments
Labels
assessment-process proposed improvements to security assessment process inactive No activity on issue/PR

Comments

@ficcaglia
Copy link

This is just a raw "meta" dump after the OPA presentation.... it seems to me that during OPA presentation the project prez was more about features. many of the questions were about specific use cases or various corner case behaviors, and the mechanisms of how OPA works in these specific cases.

IMHO neither was really focused on the security model (threats, defenses, etc) of OPA, as-is, per se.

certainly all these specific use cases and behaviors can and should inform the security model and assessment, but I think given the limited time for the group presentation, for future projects perhaps we should be more tightly focused on what the security boundaries are, the security responsibilities the project accepts as in-scope (and what they don't consider in scope), and the various threats and defenses that have been employed? rather than a discussion on how things might be differently designed or implemented.

It seemed to be at times more a debate about the pros and cons of OPA's functionality vs. the security of the already existing functionality. Should the security assessment be a debate about whether the project does a good job at X, or, given it already does X, is it doing X securely. I guess it's a question of whether the assessment is meant to debate the project itself as a useful tool for security in the CN environment, or is the assessment meant to assess the security of the project as-is, regardless of whether the as-is features are the features we as security folks would choose to implement (arguably the larger community has spoken and determined that project X is worthy of use).

Overall I expected to have more time to debate how OPA implements (or not) defenses to mutually agreed in-scope threats, but in the presentation we barely got past the high level use case/feature discussion. I felt that the document (and available supplemental slides or videos from k8s conferences, etc) explained the use cases and features sufficiently, and that everyone attending the presentation would have previously digested these so that any functionality questions are handled offline, before the prez.

I would be so bold as to suggest that perhaps the assessor present - not the project team. I think that will narrow the focus on the security aspects and the assessor's concerns, or commendations, and less the demo of the project functionality and debate about utility/design/approach of the feature set.

Not trying to be negative, though --- I thought the OPA discussion was highly useful overall, and again, this is more meta than critical commentary on OPA or the OPA assessment, per se.

@pragashj
Copy link
Collaborator

This is a useful feedback and we have a guide for assessment. It would be useful to have your comments/contribution to make it better there.

@JustinCappos
Copy link
Collaborator

I can see the merit in this. Perhaps we can try this approach for one of the upcoming assessments and see if we think it works better. I know I would have struggled to provide some of the context Ash gave about OPA because I do not know the overall project that well.

@ultrasaurus ultrasaurus added the assessment-process proposed improvements to security assessment process label May 23, 2019
@ultrasaurus
Copy link
Member

ultrasaurus commented Oct 1, 2019

In todays OPA Assessment presentation (10/1) we're going to try out a process where project lead presents "left side" (e.g. goal, design, core security analysis, maturity) and a security reviewer presents the "right side" (security risks & recommendations)

(Realize this issue was focused on presentation to SIG-Security, but figured this was relevant to the discussion) I think the format went well today.

@ficcaglia
Copy link
Author

ficcaglia commented Oct 2, 2019 via email

@stale
Copy link

stale bot commented Mar 17, 2020

This issue has been automatically marked as inactive because it has not had recent activity.

@stale stale bot added the inactive No activity on issue/PR label Mar 17, 2020
@lumjjb
Copy link
Contributor

lumjjb commented Jul 14, 2021

This is no longer relevant due to new revamped process: #488

@lumjjb lumjjb closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assessment-process proposed improvements to security assessment process inactive No activity on issue/PR
Projects
None yet
Development

No branches or pull requests

5 participants