Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 for Automation Website translations Issues Generation Ref: Issue 325 #407

Open
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

sergioarmgpl
Copy link
Contributor

Hi Dear TAG Env Team, this is the final the work that we are doing with @Dianmz.

This includes a workflow called Check outdated content, that generates new Issues for Languages for ES & ZH languages at the moment. Currently the issues are assigned to Diana and I, but should be modified to the new groups that you suggested or new ones.

The issues will look like this:
Screenshot 2024-04-30 at 22 05 41

And inside the issue will look like this:
Screenshot 2024-04-30 at 22 05 53

cc: @leonardpahlke @guidemetothemoon

sergioarmgpl and others added 30 commits April 3, 2024 22:45
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Dianmz <[email protected]>
Signed-off-by: Dianmz <[email protected]>
Signed-off-by: Dianmz <[email protected]>
Signed-off-by: Dianmz <[email protected]>
Signed-off-by: Dianmz <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>
Signed-off-by: Sergio Méndez <[email protected]>

feat: added branches main to check outdated content workflow
Signed-off-by: leonardpahlke <[email protected]>
Also includes translation of search.md file

Signed-off-by: thelooter <[email protected]>
@sergioarmgpl
Copy link
Contributor Author

I think that the duplicated part when created issues is different when using the plugin, it overwrites if the issue already exists. But I added the last 3 points that you mentioned into the issue #429. To work on it. @guidemetothemoon @Dianmz

@sergioarmgpl
Copy link
Contributor Author

@Dianmz could you double check if I missed something

@Dianmz
Copy link
Contributor

Dianmz commented Jun 6, 2024

I have just check it one more time and I think everything it's fine.

@guidemetothemoon thanks for the feed back, there are several thing we need to improve and we're going to keep on working in them in the new issues.

cc: @sergioarmgpl

@guidemetothemoon
Copy link
Contributor

@sergioarmgpl @Dianmz sounds like we have a plan! I think that it'll be good to merge this PR and start testing this, but now I see that the "Check outdated content" build is failing - can you please check and see if we can fix it? Once the build works I can merge the PR.
Thanks!

@leonardpahlke
Copy link
Member

@sergioarmgpl @Dianmz sounds like we have a plan! I think that it'll be good to merge this PR and start testing this, but now I see that the "Check outdated content" build is failing - can you please check and see if we can fix it? Once the build works I can merge the PR.

cc @Dianmz @sergioarmgpl

@leonardpahlke
Copy link
Member

  1. We need to fix the commit history: could we squash the 61 commits
  2. "Check outdated content" build is failing

@thelooter
Copy link
Contributor

  1. We need to fix the commit history: could we squash the 61 commits

As I mentioned before, this looks like a rebase failure to me

@sergioarmgpl
Copy link
Contributor Author

Hi you all, sorry for disappear, getting update to the issue, we have to activate some permissions to fix the error we noticed the message Error: An error occurred while creating the issue. This might be caused by a malformed issue title, or a typo in the labels or assignees. Check website/content/es_files.md!
To fix this we should go to cncf/tag-env-sustainability/settings/actions and activate the following permissions:
Screenshot 2024-08-26 at 21 24 28
because the step to create the issue is falling. cc: @leonardpahlke @guidemetothemoon

Sorry for the delay.

@leonardpahlke
Copy link
Member

@sergioarmgpl / @Dianmz does one of you have time to talk about the progress of this issue in this weeks TAG Meeting? cc @guidemetothemoon @catblade

@sergioarmgpl
Copy link
Contributor Author

I think that @Dianmz will be there because I will be flying at that time

@guidemetothemoon
Copy link
Contributor

I don't have access to Actions section in the Settings of this repository to fix the permission issue - @leonardpahlke do you have access and/or can provide me access for the same? Ref. comment from Sergio: #407 (comment)

@leonardpahlke
Copy link
Member

Hi you all, sorry for disappear, getting update to the issue, we have to activate some permissions to fix the error we noticed the message Error: An error occurred while creating the issue. This might be caused by a malformed issue title, or a typo in the labels or assignees. Check website/content/es_files.md!
To fix this we should go to cncf/tag-env-sustainability/settings/actions and activate the following permissions:

updated the permissions 👍

@guidemetothemoon
Copy link
Contributor

@sergioarmgpl @Dianmz one of you may need to re-queue the build or add an option to allow for manual trigger (workflow_dispatch) to test if the worfklow works after Leo has fixed the permissions.

@sergioarmgpl
Copy link
Contributor Author

@guidemetothemoon sure I will talk with @Dianmz to change it :) cc: @leonardpahlke

@sergioarmgpl
Copy link
Contributor Author

I made the change for workflow_dispatch @guidemetothemoon

Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergioarmgpl @Dianmz thanks for following up on this! Minor comment from me regarding keeping the pull_request trigger option on the workflow. Other than that, it's ready to be merged!

name: Check outdated content

on:
# pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# pull_request:
pull_request:

I guess we still want to keep pull_request option so that translation automation triggers as part of PRs but we still get an option to run it manually, on-demand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed done @guidemetothemoon

@guidemetothemoon
Copy link
Contributor

@sergioarmgpl @Dianmz looks like the workflow is failing again with some rate limit - can you please check it and let me know once it's ready so that I can do the final follow-up and get it merged? Thanks! 🙌

@sergioarmgpl
Copy link
Contributor Author

@guidemetothemoon retaking this

@sergioarmgpl
Copy link
Contributor Author

@guidemetothemoon @vallss can we rerun this I think that is related to a different thing than the implemented code.

@guidemetothemoon
Copy link
Contributor

Looking further into this now. This time it looks like GitHub PAT has expired, but I don't have access to it. I guess it's because you requested it @leonardpahlke ? Can you check, please, if it can be renewed?

@leonardpahlke
Copy link
Member

I don't see a token in this repo. I don't think its needed since its happening in the same repo (and not an external one or there is no external service that makes changes to the repo)

@guidemetothemoon
Copy link
Contributor

@leonardpahlke thanks for checking! You're right, it's the built-in GitHub Actions token that's being used.

@sergioarmgpl @Dianmz looks like the action that creates the issue is failing again with a 403 error. I'm not sure if it's because it's not merged yet but it would be good if you check it. I tried to add token permissions to the workflow file explicitly but it didn't seem to help. I also tried to check the assignee usernames since it was mentioned in an issue with similar error message, but it didn't help either: JasonEtco/create-an-issue#73

I see that someone published the same error message in the GH Actions repo a few weeks ago, so maybe it's a bug in the action itself, no reply was added yet: JasonEtco/create-an-issue#179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants