Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Connect RPC #3886

Merged
merged 4 commits into from
May 21, 2024
Merged

Adding Connect RPC #3886

merged 4 commits into from
May 21, 2024

Conversation

perezd
Copy link
Contributor

@perezd perezd commented May 18, 2024

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
  • Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
  • Have you picked the single best (existing) category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Have you added your SVG to hosted_logos and referenced it there?
  • Does your logo clearly state the name of the project/product and follow the other guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

Copy link

You can preview your changes by visiting this link.

Note

This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

Signed-off-by: Derek Perez <[email protected]>
perezd added 3 commits May 17, 2024 20:37
Signed-off-by: Derek Perez <[email protected]>
Signed-off-by: Derek Perez <[email protected]>
@perezd
Copy link
Contributor Author

perezd commented May 18, 2024

This is requested as part of sandbox onboarding: cncf/sandbox#189

@perezd
Copy link
Contributor Author

perezd commented May 18, 2024

Overlay seems stale, I don't think it's picked up some of my commits.

@tegioz
Copy link
Contributor

tegioz commented May 18, 2024

Overlay assets are served from GitHub's CDN and they usually stay cached for a few minutes.

So if you open the overlay and then push some new commits updating the same files, you may need to wait a few minutes to preview them.

Please let us know if that's not the case and you keep seeing stale content 🙂

@perezd
Copy link
Contributor Author

perezd commented May 18, 2024

@tegioz OK, everything looks correct here!

@castrojo castrojo added this pull request to the merge queue May 21, 2024
Merged via the queue into cncf:master with commit 9677d52 May 21, 2024
3 checks passed
@perezd perezd deleted the connectrpc-add branch May 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants