-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubeflow maintainers #662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR. Can we also add maintainers for the mpi-operator?
IIUC, we donated the mpi-operator to the CNCF as well: https://github.com/cncf/toc/blob/main/proposals/incubation/kubeflow.md#maintainers
Good catch. @annajung Could you add everyone listed in https://github.com/cncf/toc/blob/main/proposals/incubation/kubeflow.md#maintainers? |
@terrytangyuan The list of maintainers comes from the OWNERS file managed within these Kubeflow repos, which is more up to date than the proposal. If any modifications are needed in the list of maintainers not in the OWNERS file, I suggest modifying the OWNERS file first and updating the PR when it's OWNERS file has been updated. |
LGTM and cc @amye for merging this PR. |
This PR touches a lot more than just Kubeflow project - please revise and only add Kubeflow. |
@amye sorry, misunderstood what you meant. It's been updated now to only add Kubeflow |
LGTM |
@annajung Thank you! Sounds good. |
Much easier to have just the top level org listed instead of all orgs - you can keep your own orgs over in your repos! |
project-maintainers.csv
Outdated
@@ -1415,3 +1415,41 @@ Sandbox,kcl,Pengfei Xu,Ant Group,Peefy,https://github.com/kcl-lang/kcl/blob/main | |||
,,Xiangfei Chen,Ant Group,NeverRaR, | |||
,,Zheng Zhang,Ant Group,He1pa, | |||
,,Junxing Zhu,Southeast University,jakezhu9, | |||
Incubating,Kubeflow,James Liu,Google,zijianjoy,https://github.com/kubeflow/kubeflow/blob/master/OWNERS | |||
,,James Wu,Google,james-jwu, | |||
,,Pete MacKinnon,NVIDIA,pdmack, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably replace this with Josh Bottum.
project-maintainers.csv
Outdated
@@ -1415,3 +1415,41 @@ Sandbox,kcl,Pengfei Xu,Ant Group,Peefy,https://github.com/kcl-lang/kcl/blob/main | |||
,,Xiangfei Chen,Ant Group,NeverRaR, | |||
,,Zheng Zhang,Ant Group,He1pa, | |||
,,Junxing Zhu,Southeast University,jakezhu9, | |||
Incubating,Kubeflow,James Liu,Google,zijianjoy,https://github.com/kubeflow/kubeflow/blob/master/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably replace myself with Thea @theadactyl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the org owners file, will replace this section with the interim steering committee members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Anna Jung (VMware) <[email protected]>
Signed-off-by: Anna Jung (VMware) <[email protected]>
Signed-off-by: Anna Jung (VMware) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Anna Jung (VMware) <[email protected]>
@amye it's been updated with an aggregated list with top level instead of multiple component levels. |
Part of cncf/sandbox#196
Add Kubeflow maintainers to the maintainers list
cc
Interim Steering Committee: @james-jwu @theadactyl @jbottum
Katib: @andreyvelich @gaocegege @johnugeorge @tenzen-y
Manifests: @elikatsis @kimwnasptd @PatrickXYS @StefanoFioravanzo @yanniszark
MPI Operator: @alculquicondor @rongou @terrytangyuan
Notebooks: @elikatsis @kimwnasptd @thesuperzapper @StefanoFioravanzo @yanniszark
Pipelines: @chensun @zijianjoy @james-jwu @IronPan
Pipelines on Tekton: @animeshsingh @ckadner @fenglixa @pugangxa @ScrapCodes @Tomcli @yhwang
Training Operators: @gaocegege @Jeffwan @johnugeorge @zw0610 @terrytangyuan @tenzen-y @andreyvelich
preview: https://github.com/annajung/foundation/blob/main/project-maintainers.csv